add http known methods #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jack-berg please have a look |
jack-berg
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Looks good but need to wait for corresponding semantic-conventions PR to merge: open-telemetry/semantic-conventions#2504
|
trask
reviewed
Jul 23, 2025
Comment on lines
+91
to
+96
| "known_methods": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, |
There was a problem hiding this comment.
maybe this should be split into the client and server options below
I could almost see this option not being needed on client spans since it is primarily needed for avoiding metric cardinality attacks on servers (but I see we've defined it on both client and server spans in semconv, I don't remember if we discussed this previously, @lmolkova?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates open-telemetry/opentelemetry-java#7468